Bugfix: NPE where user has already completed all questionnaires from other job…

Bugfix: NPE where user has already completed all questionnaires from other job and thus application is NEW when submitting

cmsWebApp/src/performa/form/CompleteApplicationFP.java

@@ -4,8 +4,7 @@ import java.util.Date;
 import java.util.Map;
 import javax.servlet.http.HttpServletRequest;
 import oneit.logging.*;
-import oneit.objstore.ObjectTransaction;
-import oneit.objstore.StorageException;
+import oneit.objstore.*;
 import oneit.objstore.parser.BusinessObjectParser;
 import oneit.servlets.forms.*;
 import oneit.servlets.process.*;
@@ -22,10 +21,13 @@ public class CompleteApplicationFP extends SaveFP
     public SuccessfulResult processForm(ORMProcessState process, SubmissionDetails submission, Map params) throws BusinessException, StorageException 
     {
         HttpServletRequest  request         =   submission.getRequest();
-        ObjectTransaction   objTran         =   ObjectTransaction.getTransaction();
+        ObjectTransaction   objTran         =   ObjectTransaction.getTransaction(); //Not sure why we are using new transaction here!
         JobApplication      jobApplication  =   (JobApplication) process.getAttribute("JobApplication");
         
-        jobApplication  =   (JobApplication) jobApplication.getInTransaction (objTran);
+        if(jobApplication.getStatus() != ObjectStatus.NEW)  //getInTransaction will return NULL for NEW object, resulting NPE
+        {
+            jobApplication  =   (JobApplication) jobApplication.getInTransaction (objTran);
+        }
 
         jobApplication.setApplicationStatus(ApplicationStatus.SUBMITTED);
         jobApplication.setSubmittedDate(new Date());